Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86551?usp=email )
Change subject: soc/mediatek/mt8196: Save HW protect temperature to SRAM ......................................................................
Patch Set 4:
(3 comments)
File src/soc/mediatek/mt8196/thermal.c:
https://review.coreboot.org/c/coreboot/+/86551/comment/8cf92cf5_2a5cd50e?usp... : PS2, Line 606: if (tc_num == LVTS_AP_CONTROLLER0) : tc_index = 0; : else if (tc_num == LVTS_AP_CONTROLLER1) : tc_index = 1; : : if (tc_index != 0xff) { : thermal_write_reboot_msr_sram(tc_index, raw_high); : if (tc_index == 0) : thermal_write_reboot_temp_sram(tc->reboot_temperature); : }
patch: 86687
The patch order is wrong. @jarried.lin@mediatek.com can you organize the patches order ?
File src/soc/mediatek/mt8196/thermal_sram.c:
https://review.coreboot.org/c/coreboot/+/86551/comment/d97da93b_e8f6536e?usp... : PS4, Line 67: unsigned int `uint32_t`
https://review.coreboot.org/c/coreboot/+/86551/comment/6012b430_67278707?usp... : PS4, Line 72: int idx, unsigned int value `unsigned int idx, uint32_t value`