Attention is currently required from: Marshall Dawson, Matt Papageorge. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51957 )
Change subject: [WIP] mb/google/guybrush: add DXIO and DDI descriptors ......................................................................
Patch Set 6:
(5 comments)
File src/mainboard/google/guybrush/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/51957/comment/8037c216_87c5c6ce PS3, Line 12: .device_number = 0,
iirc that will automatically select a working configuration. […]
Done
https://review.coreboot.org/c/coreboot/+/51957/comment/7f9631c7_2645b780 PS3, Line 23: device_number = 0
- […]
Done
https://review.coreboot.org/c/coreboot/+/51957/comment/4d94cc0f_37f3db6c PS3, Line 34: device_number = 0,
- […]
Done
https://review.coreboot.org/c/coreboot/+/51957/comment/75b6c42a_24db0318 PS3, Line 45: device_number = 0,
- […]
Done
https://review.coreboot.org/c/coreboot/+/51957/comment/2773e65d_f7c1b8d3 PS3, Line 55: DDI_DP
Ok, but my previous comment still stands. […]
Done
-
Felix Held (Code Review)