Change in ...coreboot[master]: soc/intel/common/block/pcr: Remove unneded 'esle'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33336

Change subject: soc/intel/common/block/pcr: Remove unneded 'esle'
......................................................................

soc/intel/common/block/pcr: Remove unneded 'esle'

'else' is not needed after a 'break' or 'return'.

Change-Id: Ib3371ef6edb85a47ed734dd2ff9ce94008aa4e65
Signed-off-by: Elyes HAOUAS 
---
M src/soc/intel/common/block/pcr/pcr.c
1 file changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33336/1

diff --git a/src/soc/intel/common/block/pcr/pcr.c b/src/soc/intel/common/block/pcr/pcr.c
index 4a35a03..f3971c2 100644
--- a/src/soc/intel/common/block/pcr/pcr.c
+++ b/src/soc/intel/common/block/pcr/pcr.c
@@ -394,10 +394,9 @@
    		break;
    	}
    	return 0;
-	} else {
-		printk(BIOS_ERR, "SBI Failure: Transaction Status = %x\n",
-				*response);
-		return -1;
    }
+	printk(BIOS_ERR, "SBI Failure: Transaction Status = %x\n",
+			*response);
+	return -1;
 }
 #endif

[Vlado Cibic (Code Review)]

Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33336 )

Change subject: soc/intel/common/block/pcr: Remove unneded 'esle'
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33336 )

Change subject: soc/intel/common/block/pcr: Remove unneded 'esle'
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/33336/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33336/1//COMMIT_MSG@7 
PS1, Line 7: esle
else

Change in ...coreboot[master]: soc/intel/common/block/pcr: Remove unneded 'else'

[HAOUAS Elyes (Code Review)]

Hello Angel Pons, Vlado Cibic, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33336

to look at the new patch set (#2).

Change subject: soc/intel/common/block/pcr: Remove unneded 'else'
......................................................................

soc/intel/common/block/pcr: Remove unneded 'else'

'else' is not needed after a 'break' or 'return'.

Change-Id: Ib3371ef6edb85a47ed734dd2ff9ce94008aa4e65
Signed-off-by: Elyes HAOUAS 
---
M src/soc/intel/common/block/pcr/pcr.c
1 file changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33336/2

Change in ...coreboot[master]: soc/intel/common/block/pcr: Remove unneded 'else'

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33336 )

Change subject: soc/intel/common/block/pcr: Remove unneded 'else'
......................................................................

Patch Set 2: Code-Review+2

Change in ...coreboot[master]: soc/intel/common/block/pcr: Remove unneded 'else'

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33336 )

Change subject: soc/intel/common/block/pcr: Remove unneded 'else'
......................................................................

soc/intel/common/block/pcr: Remove unneded 'else'

'else' is not needed after a 'break' or 'return'.

Change-Id: Ib3371ef6edb85a47ed734dd2ff9ce94008aa4e65
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33336
Reviewed-by: Patrick Georgi 
Reviewed-by: Vlado Cibic
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/common/block/pcr/pcr.c
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Angel Pons: Looks good to me, but someone else must approve
  Vlado Cibic: Looks good to me, but someone else must approve

diff --git a/src/soc/intel/common/block/pcr/pcr.c b/src/soc/intel/common/block/pcr/pcr.c
index 4a35a03..f3971c2 100644
--- a/src/soc/intel/common/block/pcr/pcr.c
+++ b/src/soc/intel/common/block/pcr/pcr.c
@@ -394,10 +394,9 @@
    		break;
    	}
    	return 0;
-	} else {
-		printk(BIOS_ERR, "SBI Failure: Transaction Status = %x\n",
-				*response);
-		return -1;
    }
+	printk(BIOS_ERR, "SBI Failure: Transaction Status = %x\n",
+			*response);
+	return -1;
 }
 #endif

[S] Change in coreboot[master]: soc/intel/common/block/pcr: Remove unneded 'else'

[Elyes Haouas (Code Review)]

Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33336 )

Change subject: soc/intel/common/block/pcr: Remove unneded 'else'
......................................................................

Patch Set 3:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/33336/comment/efa29a33_0af0b7a9 
PS1, Line 7: esle
> else

Done