Attention is currently required from: Nico Huber, Angel Pons, Kyösti Mälkki. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49942 )
Change subject: console/printk.c: Prevent recursion in print functions ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Let me explain you the story behind this change. […]
Well... I mean a bug is still a bug and I think we should aim to fix all of those. Fundamentally I think this went the way it should... you found and fixed the underlying problem. I know console issues are annoying to debug, but they thankfully don't happen very often.
If you think it's really important to have code to better detect and explain this problem, can you maybe write it in such a way that it just prints a message (making sure that one won't be held up by recursion issues) and then die()? I really wouldn't want these issues to just silently get papered over.
-
Julius Werner (Code Review)