Attention is currently required from: Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54269 )
Change subject: mb/google/cherry: Add DRAM calibration support ......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/cherry/sdram_configs.c:
https://review.coreboot.org/c/coreboot/+/54269/comment/f8f64f55_0fb8bad8 PS6, Line 7: /* : * Currently ddr_geometry and ddr_type are not used in Cherry. : * This function is declared for common dram init flow. : */ : static struct sdram_info params; : : params.ddr_geometry = DDR_TYPE_2CH_2RK_6GB_3_3; : params.ddr_type = DDR_TYPE_EMCP; :
If MT8195 really won't use these features, then I think we should say […]
s/dummy/placeholder