Attention is currently required from: Martin Roth, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56593 )
Change subject: util/lint/lint-stable: Add forbidden Kconfig check
......................................................................
Patch Set 2:
(1 comment)
File util/lint/lint-stable-028-forbidden-config-c:
https://review.coreboot.org/c/coreboot/+/56593/comment/10627e2e_33b0b1bf
PS2, Line 10: INCLUDED_FILES='.[chsS]$|.asl$|.cb$|.ld$|.inc$'
Also .adb, . […]
Oh, I forget the syntax would be different. We'd have to grep for
`Config.CBFS_SIZE` for instance.
Also what about boolean configs? i.e. shouldn't we grep for
`CONFIG(SYMBOL)` too?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56593
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38c6062f62d28b4d54746bc6179643e675004093
Gerrit-Change-Number: 56593
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 30 Jul 2021 13:25:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment