Attention is currently required from: Shelley Chen, Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53902 )
Change subject: sc7280: Add PCIe RC driver in Coreboot ......................................................................
Patch Set 10:
(26 comments)
File src/soc/qualcomm/sc7280/include/soc/addressmap.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/b5d94c7f_9bd4698c PS10, Line 68: #define PCIE1_MEM_SIZE 0x1fd00000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/2fe8af37_ecf164cb PS10, Line 69: #define PCIE_MEM_END 0x404fffff please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/b010d383_9eb8aa5b PS10, Line 72: #define PCIE_1_QMP_PHY 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/338a1b85_eec49ed2 PS10, Line 76: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
File src/soc/qualcomm/sc7280/include/soc/pcie.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/cf9917df_171e01a7 PS10, Line 18: #define DEV_ID_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/b154fbc9_ab3b85c3 PS10, Line 19: #define CLASS_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/0e9807b6_1354fe9f PS10, Line 20: #define HEADER_SZ 8 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/b909a469_2ac4e12d PS10, Line 21: #define VEND_ID_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/444c67d4_f6ff1fc4 PS10, Line 25: #define PCIE_CLASS 0x0a please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/9a0c3437_38dafdbd PS10, Line 26: #define PCI_MAX_DEV_FN 0x100 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/1767355d_df4d0765 PS10, Line 41: #define PCIE1_3x2_NUM_LANES 2 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/470bd418_7dc80ba4 PS10, Line 57: #define PERST_DELAY_US 1000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/b3aee9de_7d3f8eab PS10, Line 58: #define PCIE_MAX_BARS 6 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/6cee383f_3195cabe PS10, Line 154: #define PCIE1_QMP_PHY_PCS_COM 0x01C0EA00 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/63f5987f_019ffee1 PS10, Line 155: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/39cab266_bbaa0fe4 PS10, Line 156: #define PCE1_QPHY_TX0 0x01C0E200 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/afd5ec99_eb904227 PS10, Line 157: #define PCE1_QPHY_RX0 0x01C0E400 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/bf65e24a_ba803ca2 PS10, Line 169: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/e7b1ca29_afca5293 PS10, Line 169: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/cb3c7c6a_fb7c72ce PS10, Line 188: #define PCIE_DEV(_bus, _dev, _fn) (0x80000000 | \ Macros with complex values should be enclosed in parentheses
File src/soc/qualcomm/sc7280/pcie_host.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/ba54bc1d_e9f336e1 PS10, Line 303: pci_ep_cfg_info.config_base = (void*)PCIE1_GEN3x2_CONF; "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/786ed5fa_b132338f PS10, Line 459: printk(BIOS_INFO,"pcie ep PERST asserted \n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/6b2cf63f_f707b594 PS10, Line 459: printk(BIOS_INFO,"pcie ep PERST asserted \n"); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/4a5c1022_d15b1b1e PS10, Line 468: printk(BIOS_NOTICE,"pcie ep PERST desserted\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/e9c3323f_fb26eb8c PS10, Line 773: if (vend_id == 0xffff || vend_id == 0x0000) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120404): https://review.coreboot.org/c/coreboot/+/53902/comment/7b044b29_cc3e1e12 PS10, Line 1140: if(!ret) space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)