Change in coreboot[master]: arch/x86/acpi_device: Constify struct device * parameter to UID funct...
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40702 )
Change subject: arch/x86/acpi_device: Constify struct device * parameter to UID functions ......................................................................
arch/x86/acpi_device: Constify struct device * parameter to UID functions
acpi_device_uid() and acpi_device_write_uid() do not need to make changes to the device structure. Thus, this change marks struct device * parameter to these functions as const.
Change-Id: I3755223766c78f93c57ac80caf392985cfd5c5e5 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/arch/x86/acpi_device.c M src/arch/x86/include/arch/acpi_device.h 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/40702/1
diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c index 9ff13e0..d80f1ac 100644 --- a/src/arch/x86/acpi_device.c +++ b/src/arch/x86/acpi_device.c @@ -95,7 +95,7 @@ * Generate unique ID based on the ACPI path. * Collisions on the same _HID are possible but very unlikely. */ -uint32_t acpi_device_uid(struct device *dev) +uint32_t acpi_device_uid(const struct device *dev) { const char *path = acpi_device_path(dev); if (!path) @@ -200,7 +200,7 @@
/* Write the unique _UID based on ACPI device path. */ -void acpi_device_write_uid(struct device *dev) +void acpi_device_write_uid(const struct device *dev) { acpigen_write_name_integer("_UID", acpi_device_uid(dev)); } diff --git a/src/arch/x86/include/arch/acpi_device.h b/src/arch/x86/include/arch/acpi_device.h index 362efc4..80dab0b 100644 --- a/src/arch/x86/include/arch/acpi_device.h +++ b/src/arch/x86/include/arch/acpi_device.h @@ -52,12 +52,12 @@ struct device; const char *acpi_device_name(const struct device *dev); const char *acpi_device_hid(const struct device *dev); -uint32_t acpi_device_uid(struct device *dev); +uint32_t acpi_device_uid(const struct device *dev); const char *acpi_device_path(const struct device *dev); const char *acpi_device_scope(const struct device *dev); const char *acpi_device_path_join(const struct device *dev, const char *name); int acpi_device_status(const struct device *dev); -void acpi_device_write_uid(struct device *dev); +void acpi_device_write_uid(const struct device *dev);
/* * ACPI Descriptor for extended Interrupt()
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40702 )
Change subject: arch/x86/acpi_device: Constify struct device * parameter to UID functions ......................................................................
Patch Set 5: Code-Review+1
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40702 )
Change subject: arch/x86/acpi_device: Constify struct device * parameter to UID functions ......................................................................
Patch Set 5: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40702 )
Change subject: arch/x86/acpi_device: Constify struct device * parameter to UID functions ......................................................................
Patch Set 5: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40702 )
Change subject: arch/x86/acpi_device: Constify struct device * parameter to UID functions ......................................................................
arch/x86/acpi_device: Constify struct device * parameter to UID functions
acpi_device_uid() and acpi_device_write_uid() do not need to make changes to the device structure. Thus, this change marks struct device * parameter to these functions as const.
Change-Id: I3755223766c78f93c57ac80caf392985cfd5c5e5 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40702 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/x86/acpi_device.c M src/arch/x86/include/arch/acpi_device.h 2 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved
diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c index 2c46155..1dc471c 100644 --- a/src/arch/x86/acpi_device.c +++ b/src/arch/x86/acpi_device.c @@ -95,7 +95,7 @@ * Generate unique ID based on the ACPI path. * Collisions on the same _HID are possible but very unlikely. */ -uint32_t acpi_device_uid(struct device *dev) +uint32_t acpi_device_uid(const struct device *dev) { const char *path = acpi_device_path(dev); if (!path) @@ -200,7 +200,7 @@
/* Write the unique _UID based on ACPI device path. */ -void acpi_device_write_uid(struct device *dev) +void acpi_device_write_uid(const struct device *dev) { acpigen_write_name_integer("_UID", acpi_device_uid(dev)); } diff --git a/src/arch/x86/include/arch/acpi_device.h b/src/arch/x86/include/arch/acpi_device.h index 362efc4..80dab0b 100644 --- a/src/arch/x86/include/arch/acpi_device.h +++ b/src/arch/x86/include/arch/acpi_device.h @@ -52,12 +52,12 @@ struct device; const char *acpi_device_name(const struct device *dev); const char *acpi_device_hid(const struct device *dev); -uint32_t acpi_device_uid(struct device *dev); +uint32_t acpi_device_uid(const struct device *dev); const char *acpi_device_path(const struct device *dev); const char *acpi_device_scope(const struct device *dev); const char *acpi_device_path_join(const struct device *dev, const char *name); int acpi_device_status(const struct device *dev); -void acpi_device_write_uid(struct device *dev); +void acpi_device_write_uid(const struct device *dev);
/* * ACPI Descriptor for extended Interrupt()
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
HAOUAS Elyes (Code Review)