Attention is currently required from: Hung-Te Lin, Paul Menzel.
jason-ch chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74062 )
Change subject: soc/mediatek/mt8186: Reduce GPIO code size in bootblock
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74062/comment/4b139bb5_926b1a24
PS3, Line 2: jason-ch chen
Is your name written jason-ch? You could also use a capital first letter.
Done
https://review.coreboot.org/c/coreboot/+/74062/comment/cc69ed23_1019d5e0
PS3, Line 8:
Please describe the problem, and mention the sizes before and after.
Done
https://review.coreboot.org/c/coreboot/+/74062/comment/1d5efbc3_bebb25d1
PS3, Line 13: jason-ch chen
Ditto.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74062
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24775ba93cd74ae401747c2f5a26bbf1c8f6ac0a
Gerrit-Change-Number: 74062
Gerrit-PatchSet: 4
Gerrit-Owner: jason-ch chen
Jason-ch.Chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 06 Apr 2023 08:26:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment