Change in coreboot[master]: mainboard/hatch: Move GPP_A11 config into variants from baseboard

[Edward O'Callaghan (Code Review)]

Hello Edward O'Callaghan,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/37590

to review the following change.

Change subject: mainboard/hatch: Move GPP_A11 config into variants from baseboard
......................................................................

mainboard/hatch: Move GPP_A11 config into variants from baseboard

Not all Hatch variants have a FP reader and so the baseboard should not
assume one is connected. Instead the baseboard defines A11 as NC unless
the variant defines it otherwise by override.

Also, kindred has no FP so fix that while we are here.

BUG=b:144809606
BRANCH=hatch
TEST=none

Change-Id: Ib4fa6ccfe746fe8e8b64b082c68d76cdc34cf8fb
Signed-off-by: Edward O'Callaghan 
---
M src/mainboard/google/hatch/variants/akemi/gpio.c
M src/mainboard/google/hatch/variants/baseboard/gpio.c
M src/mainboard/google/hatch/variants/dratini/gpio.c
M src/mainboard/google/hatch/variants/hatch/gpio.c
M src/mainboard/google/hatch/variants/helios/gpio.c
M src/mainboard/google/hatch/variants/jinlon/gpio.c
M src/mainboard/google/hatch/variants/kohaku/gpio.c
M src/mainboard/google/hatch/variants/stryke/gpio.c
8 files changed, 12 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/37590/1

diff --git a/src/mainboard/google/hatch/variants/akemi/gpio.c b/src/mainboard/google/hatch/variants/akemi/gpio.c
index 4be3c34..0be39b7 100644
--- a/src/mainboard/google/hatch/variants/akemi/gpio.c
+++ b/src/mainboard/google/hatch/variants/akemi/gpio.c
@@ -27,8 +27,6 @@
    PAD_NC(GPP_A8, NONE),
    /* A10 : NC */
    PAD_NC(GPP_A10, NONE),
-	/* A11 : NC */
-	PAD_NC(GPP_A11, NONE),
    /* A12 : NC */
    PAD_NC(GPP_A12, NONE),
    /* A18 : NC */
@@ -98,8 +96,6 @@
    PAD_NC(GPP_A8, NONE),
    /* A10 : NC */
    PAD_NC(GPP_A10, NONE),
-	/* A11 : NC */
-	PAD_NC(GPP_A11, NONE),
    /* A12 : NC */
    PAD_NC(GPP_A12, NONE),
    /* A18 : NC */
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c
index 029aba16..2bc843e 100644
--- a/src/mainboard/google/hatch/variants/baseboard/gpio.c
+++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c
@@ -35,8 +35,8 @@
    /* A9  : ESPI_CLK */
    /* A10 : FPMCU_PCH_BOOT1 */
    PAD_CFG_GPO(GPP_A10, 0, DEEP),
-	/* A11 : PCH_SPI_FPMCU_CS_L */
-	PAD_CFG_NF(GPP_A11, NONE, DEEP, NF2),
+	/* A11 : GPP_A11 ==> NC */
+	PAD_NC(GPP_A11, NONE),
    /* A12 : FPMCU_RST_ODL */
    PAD_CFG_GPO(GPP_A12, 1, DEEP),
    /* A13 : SUSWARN_L */
diff --git a/src/mainboard/google/hatch/variants/dratini/gpio.c b/src/mainboard/google/hatch/variants/dratini/gpio.c
index 30d56d7..0b5d0de 100644
--- a/src/mainboard/google/hatch/variants/dratini/gpio.c
+++ b/src/mainboard/google/hatch/variants/dratini/gpio.c
@@ -27,6 +27,8 @@
    PAD_NC(GPP_A8, NONE),
    /* A10 : NC */
    PAD_NC(GPP_A10, NONE),
+	/* A11 : PCH_SPI_FPMCU_CS_L */
+	PAD_CFG_NF(GPP_A11, NONE, DEEP, NF2),
    /* A18 : NC */
    PAD_NC(GPP_A18, NONE),
    /* A19 : NC */
diff --git a/src/mainboard/google/hatch/variants/hatch/gpio.c b/src/mainboard/google/hatch/variants/hatch/gpio.c
index 56f587b..def6ff0 100644
--- a/src/mainboard/google/hatch/variants/hatch/gpio.c
+++ b/src/mainboard/google/hatch/variants/hatch/gpio.c
@@ -19,6 +19,8 @@
 #include <commonlib/helpers.h>

static const struct pad_config gpio_table[] = {
+	/* A11 : PCH_SPI_FPMCU_CS_L */
+	PAD_CFG_NF(GPP_A11, NONE, DEEP, NF2),
    /* C13 : EC_PCH_INT_L */
    PAD_CFG_GPI_APIC(GPP_C13, UP_20K, PLTRST, LEVEL, INVERT)};

diff --git a/src/mainboard/google/hatch/variants/helios/gpio.c b/src/mainboard/google/hatch/variants/helios/gpio.c
index 85eb3fc..89c6b41 100644
--- a/src/mainboard/google/hatch/variants/helios/gpio.c
+++ b/src/mainboard/google/hatch/variants/helios/gpio.c
@@ -23,6 +23,8 @@
    PAD_NC(GPP_A0, NONE),
    /* A6  : SERIRQ ==> NC */
    PAD_NC(GPP_A6, NONE),
+	/* A11 : PCH_SPI_FPMCU_CS_L */
+	PAD_CFG_NF(GPP_A11, NONE, DEEP, NF2),
    /* A18 : ISH_GP0 ==> NC */
    PAD_NC(GPP_A18, NONE),
    /* A19 : ISH_GP1 ==> NC */
diff --git a/src/mainboard/google/hatch/variants/jinlon/gpio.c b/src/mainboard/google/hatch/variants/jinlon/gpio.c
index 7e475fa..bf94edb 100644
--- a/src/mainboard/google/hatch/variants/jinlon/gpio.c
+++ b/src/mainboard/google/hatch/variants/jinlon/gpio.c
@@ -27,6 +27,8 @@
    PAD_NC(GPP_A8, NONE),
    /* A10 : NC */
    PAD_NC(GPP_A10, NONE),
+	/* A11 : PCH_SPI_FPMCU_CS_L */
+	PAD_CFG_NF(GPP_A11, NONE, DEEP, NF2),
    /* C12 : FPMCU_PCH_BOOT1 */
    PAD_CFG_GPO(GPP_C12, 0, DEEP),
    /* F1  : NC */
diff --git a/src/mainboard/google/hatch/variants/kohaku/gpio.c b/src/mainboard/google/hatch/variants/kohaku/gpio.c
index 4ebd258..49798c3 100644
--- a/src/mainboard/google/hatch/variants/kohaku/gpio.c
+++ b/src/mainboard/google/hatch/variants/kohaku/gpio.c
@@ -25,6 +25,8 @@
    PAD_NC(GPP_A6, NONE),
    /* A10 : GPP_A10 ==> NC */
    PAD_NC(GPP_A10, NONE),
+	/* A11 : PCH_SPI_FPMCU_CS_L */
+	PAD_CFG_NF(GPP_A11, NONE, DEEP, NF2),
    /* A16 : EMR_GARAGE_DET (notification) */
    PAD_CFG_GPI_GPIO_DRIVER(GPP_A16, NONE, PLTRST),
    /* A17 : PIRQA# ==> NC */
diff --git a/src/mainboard/google/hatch/variants/stryke/gpio.c b/src/mainboard/google/hatch/variants/stryke/gpio.c
index 4d27554..814f2a6 100644
--- a/src/mainboard/google/hatch/variants/stryke/gpio.c
+++ b/src/mainboard/google/hatch/variants/stryke/gpio.c
@@ -27,8 +27,6 @@
    PAD_NC(GPP_A8, NONE),
    /* A10 : NC */
    PAD_NC(GPP_A10, NONE),
-	/* A11 : NC */
-	PAD_NC(GPP_A11, NONE),
    /* A12 : NC */
    PAD_NC(GPP_A12, NONE),
    /* A22 : NC */

[Kangheui Won (Code Review)]

Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37590 )

Change subject: mainboard/hatch: Move GPP_A11 config into variants from baseboard
......................................................................

Patch Set 2: Code-Review+1

[S] Change in coreboot[master]: mainboard/hatch: Move GPP_A11 config into variants from baseboard

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37590?usp=email )

Change subject: mainboard/hatch: Move GPP_A11 config into variants from baseboard
......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.