Attention is currently required from: Raul Rangel, Furquan Shaikh, Martin Roth, Karthik Ramasubramanian. Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55148 )
Change subject: mb/google/guybrush/var/guybrush: Update GPIO configuration ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55148/comment/2bf8a2db_dfdb0460 PS1, Line 14: TP183
Looks like this was configured as NF (SPI_CS3_L)?
it was unused. Ought to comment as such. https://b.corp.google.com/issues/188542649#comment3
https://review.coreboot.org/c/coreboot/+/55148/comment/ff16546d_ddb32823 PS1, Line 20: TEST=Build Guybrush mainboard. probably need a boot board id #1 as well and confirm Speaker and reset are working. I realize we can't test id2 yet, but we can backtest id1.
File src/mainboard/google/guybrush/variants/guybrush/gpio.c:
https://review.coreboot.org/c/coreboot/+/55148/comment/15f9bee5_6ff3169d PS1, Line 14: HIGH
This was set to LOW because of the incorrect voltage rating. […]
1.8V target as per b/188542497
-
Eric Peers (Code Review)