Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Christian Walter, Lean Sheng Tan, Patrick Rudolph, Paul Menzel.
Leon Groß has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77905?usp=email )
Change subject: mb/emulation: Add SIMICS QSP support ......................................................................
Patch Set 11:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/77905/comment/8391f57d_ce1c09af : PS9, Line 7: emualtion
emulation
Done
https://review.coreboot.org/c/coreboot/+/77905/comment/0f3177eb_2a6ce1f4 : PS9, Line 9: ,
Maybe a colon?
Done
https://review.coreboot.org/c/coreboot/+/77905/comment/a5035cf7_0aff8ae8 : PS9, Line 9: SIMICS QSP
What is that?
Quick Start Platfrom (QSP)
https://review.coreboot.org/c/coreboot/+/77905/comment/b91ff7f8_1e56d3d9 : PS9, Line 10: on
an
Done
File src/mainboard/emulation/simics-qsp/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/77905/comment/823aa780_6cd72630 : PS4, Line 365: /**************************************************************** : * General purpose events : ****************************************************************/ : : Scope(_GPE) { : Name(_HID, "ACPI0006") : : Method(_L00) { : } : Method(_L01) { : } : Method(_L02) { : } : Method(_L03) { : } : Method(_L04) { : } : Method(_L05) { : } : Method(_L06) { : } : Method(_L07) { : } : Method(_L08) { : } : Method(_L09) { : } : Method(_L0A) { : } : Method(_L0B) { : } : Method(_L0C) { : } : Method(_L0D) { : } : Method(_L0E) { : } : Method(_L0F) { : } : }
remove?
I'm not an expert on ACPI, but I thought in other
-
Leon Groß (Code Review)