Attention is currently required from: Angel Pons. Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52344 )
Change subject: mb/asus/p8z77-v_lx2: Add CMOS option support ......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/asus/p8z77-v_lx2/cmos.layout:
https://review.coreboot.org/c/coreboot/+/52344/comment/3536459d_97668f8d PS4, Line 20: 400 1 e 1 hyper_threading
No. […]
intel_sibling_init() @ src/cpu/intel/hyperthreading/intel_sibling.c, though this function seems not used on Sandy/Ivy Bridge yet. Since CB:29669 does not touch this board yet, I suggest leaving this option here.
File src/mainboard/asus/p8z77-v_lx2/cmos.layout:
https://review.coreboot.org/c/coreboot/+/52344/comment/643e6b5e_15cf27d7 PS5, Line 25: 1
2 bits
Done
https://review.coreboot.org/c/coreboot/+/52344/comment/c0d699a2_5f2bdc8f PS5, Line 25: 1
2 bits
Done
https://review.coreboot.org/c/coreboot/+/52344/comment/5ae696a2_8cc3a084 PS5, Line 98: 6 30 992M
Encoding is non-linear: https://imgur.com/kiRxPst.png […]
Done
-
Bill XIE (Code Review)