Change in coreboot[master]: mb/prodrive/hermes: Set mb_hda_amp_enable based on cfg - coreboot-gerrit

8 Feb 2021


      Attention is currently required from: Patrick Rudolph, Christian Walter.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50381 )
Change subject: mb/prodrive/hermes: Set mb_hda_amp_enable based on cfg
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/prodrive/hermes/mainboard.c:
https://review.coreboot.org/c/coreboot/+/50381/comment/42bf3425_696cda56 
PS1, Line 71: 	if (board_cfg->internal_audio_connection == 2)
Should we add an enum?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50381
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13c2ece729128fe245de88c0d36ce7b4bcaf6b6d
Gerrit-Change-Number: 50381
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Comment-Date: Mon, 08 Feb 2021 10:19:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment