Change in coreboot[master]: mb/google/var/banshee: Add gpios to lock - coreboot-gerrit

7 Feb 2022


      Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, EricR Lai.
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61663 )
Change subject: mb/google/var/banshee: Add gpios to lock
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/banshee/gpio.c:
https://review.coreboot.org/c/coreboot/+/61663/comment/30cfc597_1efa496b 
PS1, Line 148: 	PAD_NC(GPP_E17, NONE),
Should this be PAD_NC_LOCK(GPP_E17, NONE, LOCK_CONFIG)?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/61663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5a2136e57e842fbd0b2c2836833106e7344afee
Gerrit-Change-Number: 61663
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 07 Feb 2022 07:43:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment