Attention is currently required from: Kevin Chiu, Paul Menzel.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77634?usp=email )
Change subject: device/pci_rom: rename pci_rom_acpi_fill_vfct() ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/77634/comment/416a1069_6391d92d : PS2, Line 7: rename pci_rom_acpi_fill_vfct()
Maybe also add the new name: […]
too long for subject line
https://review.coreboot.org/c/coreboot/+/77634/comment/f4d8c745_a1594005 : PS2, Line 9: ati_rom_acpi_fill_vfct
should be "pci_rom_acpi_fill_vfct"?
Done
https://review.coreboot.org/c/coreboot/+/77634/comment/6a2d2609_d26d33a8 : PS2, Line 9: to to
to
Done
File src/device/pci_rom.c:
https://review.coreboot.org/c/coreboot/+/77634/comment/a1c7de63_376b1685 : PS2, Line 222: ati_rom_acpi_fill_vfct
Should it be *amd* instead of *ati*?
no, because AMD bought ATI years ago, but still uses ATI's PCI ID. the function is only called for devices with ATI's PCI ID