Change in coreboot[master]: i82371eb: Drop KB/Mouse/FDC declarations

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Keith Hui (Code Review)

28 Jan 2020 28 Jan '20

12:27 a.m.

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38600 )

Change subject: i82371eb: Drop KB/Mouse/FDC declarations ......................................................................

i82371eb: Drop KB/Mouse/FDC declarations

These are declared by superio.

Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Signed-off-by: Keith Hui buurin@gmail.com --- M src/southbridge/intel/i82371eb/acpi/isabridge.asl 1 file changed, 0 insertions(+), 68 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/38600/1

diff --git a/src/southbridge/intel/i82371eb/acpi/isabridge.asl b/src/southbridge/intel/i82371eb/acpi/isabridge.asl index 2f842d6..6a0cd45 100644 --- a/src/southbridge/intel/i82371eb/acpi/isabridge.asl +++ b/src/southbridge/intel/i82371eb/acpi/isabridge.asl @@ -14,74 +14,6 @@ * GNU General Public License for more details. */

-/* - * ISA portions taken from QEMU acpi-dsdt.dsl. - */ - -// Intel LPC Bus Device - 0:4.0 -Device (LPCB) -{ - Name(_ADR, 0x00040000) - - OperationRegion(PCIC, PCI_Config, 0x00, 0x100) - - /* PS/2 keyboard (seems to be important for WinXP install) */ - Device (KBD) - { - Name (_HID, EisaId ("PNP0303")) - Method (_STA, 0, NotSerialized) - { - Return (0x0f) - } - Method (_CRS, 0, NotSerialized) - { - Name (TMP, ResourceTemplate () { - IO (Decode16, 0x0060, 0x0060, 0x01, 0x01) - IO (Decode16, 0x0064, 0x0064, 0x01, 0x01) - IRQNoFlags () {1} - }) - Return (TMP) - } - } - - /* PS/2 mouse */ - Device (MOU) - { - Name (_HID, EisaId ("PNP0F13")) - Method (_STA, 0, NotSerialized) - { - Return (0x0f) - } - Method (_CRS, 0, NotSerialized) - { - Name (TMP, ResourceTemplate () { - IRQNoFlags () {12} - }) - Return (TMP) - } - } - - /* PS/2 floppy controller */ - Device (FDC0) - { - Name (_HID, EisaId ("PNP0700")) - Method (_STA, 0, NotSerialized) - { - Return (0x0f) - } - Method (_CRS, 0, NotSerialized) - { - Name (BUF0, ResourceTemplate () { - IO (Decode16, 0x03F2, 0x03F2, 0x00, 0x04) - IO (Decode16, 0x03F7, 0x03F7, 0x00, 0x01) - IRQNoFlags () {6} - DMA (Compatibility, NotBusMaster, Transfer8) {2} - }) - Return (BUF0) - } - } -} - Device(MBRS) { Name (_HID, EisaId ("PNP0C02")) Name (_UID, 0x01)

Attachments:

attachment.htm (text/html — 7.0 KB)

Show replies by date

Paul Menzel (Code Review)

28 Jan 28 Jan

1:51 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38600 )

Change subject: i82371eb: Drop KB/Mouse/FDC declarations ......................................................................

Patch Set 2:

(2 comments)

Did you verify, that `acpidump` still contains that?

https://review.coreboot.org/c/coreboot/+/38600/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38600/2//COMMIT_MSG@7 PS2, Line 7: i82371eb sb/intel/i82371cb:

https://review.coreboot.org/c/coreboot/+/38600/2/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/acpi/isabridge.asl:

https://review.coreboot.org/c/coreboot/+/38600/2/src/southbridge/intel/i8237... PS2, Line 83: } I do not see these parts in `src/superio/winbond/w83977tf/acpi/`.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Gerrit-Change-Number: 38600 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 28 Jan 2020 12:51:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Keith Hui (Code Review)

2:35 p.m.

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38600 )

Change subject: i82371eb: Drop KB/Mouse/FDC declarations ......................................................................

Patch Set 2:

(1 comment)

I checked our dsdt against ones extracted from factory bios images for the entire p2b family.

Oh and this file was not referenced anywhere else until another patch down this train.

https://review.coreboot.org/c/coreboot/+/38600/2/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/acpi/isabridge.asl:

https://review.coreboot.org/c/coreboot/+/38600/2/src/southbridge/intel/i8237... PS2, Line 83: }

...

I do not see these parts in `src/superio/winbond/w83977tf/acpi/`.

It imports a common pnp declaration from superio/common

-- To view, visit https://review.coreboot.org/c/coreboot/+/38600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Gerrit-Change-Number: 38600 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 28 Jan 2020 13:35:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Paul Menzel (Code Review)

3:59 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38600 )

Change subject: i82371eb: Drop KB/Mouse/FDC declarations ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38600/2/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/acpi/isabridge.asl:

https://review.coreboot.org/c/coreboot/+/38600/2/src/southbridge/intel/i8237... PS2, Line 83: }

...

It imports a common pnp declaration from superio/common

Did you test a PS/2 mouse? I find KBC definitions(?) in `src/superio/acpi/`, but not MOU and FDC0.

``` $ git grep MOU src/superio/ src/superio/common/ssdt.c: {ACPI_HID_MOUSE, {60, 64, }, {12, } }, src/superio/common/ssdt.c: {ACPI_HID_MOUSE, "PS2 Mouse"}, src/superio/ite/it8783ef/acpi/superio.asl: * 0x6 MOUSE Implemented, untested src/superio/ite/it8786e/acpi/superio.asl: * 0x6 MOUSE Implemented, untested $ git grep FDC0 src/superio/ src/superio/ite/it8772f/acpi/superio.asl:#ifdef SIO_ENABLE_FDC0 src/superio/ite/it8772f/acpi/superio.asl: Device (FDC0) // Floppy controller src/superio/smsc/sio1007/acpi/superio.asl:#ifdef SIO_ENABLE_FDC0 src/superio/smsc/sio1007/acpi/superio.asl: Device (FDC0) // Floppy controller src/superio/winbond/w83627hf/acpi/superio.asl: Device (FDC0) { src/superio/winbond/w83977tf/acpi/superio.asl:Device (FDC0) ```

-- To view, visit https://review.coreboot.org/c/coreboot/+/38600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Gerrit-Change-Number: 38600 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 28 Jan 2020 14:59:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Keith Hui buurin@gmail.com Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Angel Pons (Code Review)

2 Feb 2 Feb

1:19 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38600 )

Change subject: i82371eb: Drop KB/Mouse/FDC declarations ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Gerrit-Change-Number: 38600 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 02 Feb 2020 12:19:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Keith Hui (Code Review)

7:14 p.m.

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38600 )

Change subject: i82371eb: Drop KB/Mouse/FDC declarations ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38600/2/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/acpi/isabridge.asl:

https://review.coreboot.org/c/coreboot/+/38600/2/src/southbridge/intel/i8237... PS2, Line 83: }

...

Did you test a PS/2 mouse? I find KBC definitions(?) in `src/superio/acpi/`, but not MOU and FDC0. […]

Mouse works. Just tested using gpm.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Gerrit-Change-Number: 38600 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 02 Feb 2020 18:14:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Keith Hui buurin@gmail.com Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Keith Hui (Code Review)

17 Mar 17 Mar

1:59 a.m.

New subject: Change in coreboot[master]: sb/intel/i82371eb: Drop KB/Mouse/FDC declarations

Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38600

to look at the new patch set (#3).

Change subject: sb/intel/i82371eb: Drop KB/Mouse/FDC declarations ......................................................................

sb/intel/i82371eb: Drop KB/Mouse/FDC declarations

These are declared by superio.

Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Signed-off-by: Keith Hui buurin@gmail.com --- M src/southbridge/intel/i82371eb/acpi/isabridge.asl 1 file changed, 0 insertions(+), 68 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/38600/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/38600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Gerrit-Change-Number: 38600 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Keith Hui (Code Review)

2:01 a.m.

New subject: Change in coreboot[master]: sb/intel/i82371eb: Drop KB/Mouse/FDC declarations

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38600 )

Change subject: sb/intel/i82371eb: Drop KB/Mouse/FDC declarations ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38600/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38600/2//COMMIT_MSG@7 PS2, Line 7: i82371eb

...

sb/intel/i82371cb:

Done

https://review.coreboot.org/c/coreboot/+/38600/2/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/acpi/isabridge.asl:

https://review.coreboot.org/c/coreboot/+/38600/2/src/southbridge/intel/i8237... PS2, Line 83: }

...

Mouse works. Just tested using gpm.

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/38600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Gerrit-Change-Number: 38600 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 17 Mar 2020 01:01:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Keith Hui buurin@gmail.com Gerrit-MessageType: comment

Keith Hui (Code Review)

29 Mar 29 Mar

4:32 a.m.

Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38600

to look at the new patch set (#5).

Change subject: i82371eb: Drop KB/Mouse/FDC declarations ......................................................................

i82371eb: Drop KB/Mouse/FDC declarations

These are declared by superio.

Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Signed-off-by: Keith Hui buurin@gmail.com --- M src/southbridge/intel/i82371eb/acpi/isabridge.asl 1 file changed, 0 insertions(+), 68 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/38600/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/38600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Gerrit-Change-Number: 38600 Gerrit-PatchSet: 5 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Keith Hui (Code Review)

5:45 a.m.

Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38600

to look at the new patch set (#6).

Change subject: i82371eb: Drop KB/Mouse/FDC declarations ......................................................................

i82371eb: Drop KB/Mouse/FDC declarations

These are declared by superio.

Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Signed-off-by: Keith Hui buurin@gmail.com --- M src/southbridge/intel/i82371eb/acpi/isabridge.asl 1 file changed, 0 insertions(+), 68 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/38600/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/38600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Gerrit-Change-Number: 38600 Gerrit-PatchSet: 6 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

9:13 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38600 )

Change subject: i82371eb: Drop KB/Mouse/FDC declarations ......................................................................

Patch Set 6: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/38600/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38600/6//COMMIT_MSG@7 PS6, Line 7: KB KBD?

https://review.coreboot.org/c/coreboot/+/38600/6//COMMIT_MSG@9 PS6, Line 9: by superio by the Super I/O.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Gerrit-Change-Number: 38600 Gerrit-PatchSet: 6 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 29 Mar 2020 19:13:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

18 Apr 18 Apr

8:52 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38600 )

Change subject: i82371eb: Drop KB/Mouse/FDC declarations ......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38600/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38600/6//COMMIT_MSG@7 PS6, Line 7: KB

...

KBD?

Ack

https://review.coreboot.org/c/coreboot/+/38600/6//COMMIT_MSG@9 PS6, Line 9: by superio

...

by the Super I/O.

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/38600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Gerrit-Change-Number: 38600 Gerrit-PatchSet: 8 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 18 Apr 2020 18:52:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

8:52 p.m.

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38600 )

Change subject: i82371eb: Drop KB/Mouse/FDC declarations ......................................................................

i82371eb: Drop KB/Mouse/FDC declarations

These are declared by superio.

Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38600 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/i82371eb/acpi/isabridge.asl 1 file changed, 0 insertions(+), 68 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/src/southbridge/intel/i82371eb/acpi/isabridge.asl b/src/southbridge/intel/i82371eb/acpi/isabridge.asl index 55a0ca5..1298618 100644 --- a/src/southbridge/intel/i82371eb/acpi/isabridge.asl +++ b/src/southbridge/intel/i82371eb/acpi/isabridge.asl @@ -1,74 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */

-- To view, visit https://review.coreboot.org/c/coreboot/+/38600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Gerrit-Change-Number: 38600 Gerrit-PatchSet: 9 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

9:11 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38600 )

Change subject: i82371eb: Drop KB/Mouse/FDC declarations ......................................................................

Patch Set 9:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2456 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2455 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2454 EMULATION_QEMU_AARCH64_FIT_SUPPORT_TIMESTAMPS using payload LinuxBoot_u-root_kexec_AARCH64 : SUCCESS : https://lava.9esec.io/r/2453

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/38600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1db4aca7d682ec298b8f53cfab6ffe661e8ff6e0 Gerrit-Change-Number: 38600 Gerrit-PatchSet: 9 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 18 Apr 2020 19:11:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1847

days inactive

1929

days old

coreboot-gerrit@coreboot.org

13 comments

4 participants

tags (0)

participants (4)

9elements QA (Code Review)
Angel Pons (Code Review)
Keith Hui (Code Review)
Paul Menzel (Code Review)