HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32677
Change subject: sb/i82801gx: Remove duplicated 'define PMBASE' ......................................................................
sb/i82801gx: Remove duplicated 'define PMBASE'
Change-Id: If08bea821043bc8e661bf5327f4fe2cef3a65be8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/i82801gx/i82801gx.h 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/32677/1
diff --git a/src/southbridge/intel/i82801gx/i82801gx.h b/src/southbridge/intel/i82801gx/i82801gx.h index 3db5d49..b693b75 100644 --- a/src/southbridge/intel/i82801gx/i82801gx.h +++ b/src/southbridge/intel/i82801gx/i82801gx.h @@ -89,7 +89,6 @@ #define RTC_POWER_FAILED (1 << 1) #define SLEEP_AFTER_POWER_FAIL (1 << 0)
-#define PMBASE 0x40 #define ACPI_CNTL 0x44 #define ACPI_EN (1 << 7) #define BIOS_CNTL 0xDC
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32677 )
Change subject: sb/i82801gx: Remove duplicated 'define PMBASE' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32677/1/src/southbridge/intel/i82801gx/i8280... File src/southbridge/intel/i82801gx/i82801gx.h:
https://review.coreboot.org/#/c/32677/1/src/southbridge/intel/i82801gx/i8280... PS1, Line 185: duplicated
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32677 )
Change subject: sb/i82801gx: Remove duplicated 'define PMBASE' ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32677 )
Change subject: sb/i82801gx: Remove duplicated 'define PMBASE' ......................................................................
sb/i82801gx: Remove duplicated 'define PMBASE'
Change-Id: If08bea821043bc8e661bf5327f4fe2cef3a65be8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32677 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/southbridge/intel/i82801gx/i82801gx.h 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/southbridge/intel/i82801gx/i82801gx.h b/src/southbridge/intel/i82801gx/i82801gx.h index 3db5d49..b693b75 100644 --- a/src/southbridge/intel/i82801gx/i82801gx.h +++ b/src/southbridge/intel/i82801gx/i82801gx.h @@ -89,7 +89,6 @@ #define RTC_POWER_FAILED (1 << 1) #define SLEEP_AFTER_POWER_FAIL (1 << 0)
-#define PMBASE 0x40 #define ACPI_CNTL 0x44 #define ACPI_EN (1 << 7) #define BIOS_CNTL 0xDC
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)