Change in coreboot[master]: driver/usb/acpi: Add power resources for devices on USB ports - coreboot-gerrit

3 Nov 2020


      Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46713 )
Change subject: driver/usb/acpi: Add power resources for devices on USB ports
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46713/2/src/drivers/usb/acpi/usb_ac... 
File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/46713/2/src/drivers/usb/acpi/usb_ac... 
PS2, Line 65: * Should we apply Power Resource only for Internal ports. *
...
Yes.
I think it can be left upto the mainboard to decide based on hardware design?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/46713
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc1aebfb9e3e646a7f608f0cd391079fd30dd1c0
Gerrit-Change-Number: 46713
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 03 Nov 2020 01:01:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment