Change in em100[master]: Allow serial numbers beginning with EM

[Chris K (Code Review)]

Hello Chris Koch,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/em100/+/37624

to review the following change.

Change subject: Allow serial numbers beginning with EM
......................................................................

Allow serial numbers beginning with EM

Newer em100s have serial numbers beginning with EM instead of DP.

Signed-off-by: Chris Koch 
Change-Id: I6f4b3b0900fe1b5c776acd02f54ca97b31d85420
---
M em100.c
1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/em100 refs/changes/24/37624/1

diff --git a/em100.c b/em100.c
index 1ee22ec..46f2c64 100644
--- a/em100.c
+++ b/em100.c
@@ -878,8 +878,10 @@
    		firmware_is_dpfw = 1;
    		break;
    	case 'x':
-			if ((optarg[0] == 'D' || optarg[0] == 'd') &&
-				(optarg[1] == 'P' || optarg[1] == 'p'))
+			if (((optarg[0] == 'D' || optarg[0] == 'd') &&
+				(optarg[1] == 'P' || optarg[1] == 'p')) ||
+				((optarg[0] == 'E' || optarg[0] == 'e') &&
+				(optarg[1] == 'M' || optarg[1] == 'm')))
    			sscanf(optarg + 2, "%d", &serial_number);
    		else
    			sscanf(optarg, "%d:%d", &bus, &device);

[Chris K (Code Review)]

Chris K has removed Chris Koch from this change.  ( https://review.coreboot.org/c/em100/+/37624 )

Change subject: Allow serial numbers beginning with EM
......................................................................

Removed reviewer Chris Koch.

[Ryan O'Leary (Code Review)]

Ryan O'Leary has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37624 )

Change subject: Allow serial numbers beginning with EM
......................................................................

Patch Set 1: Code-Review+1

[Stefan Reinauer (Code Review)]

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37624 )

Change subject: Allow serial numbers beginning with EM
......................................................................

Patch Set 1: Code-Review+2

[Stefan Reinauer (Code Review)]

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/37624 )

Change subject: Allow serial numbers beginning with EM
......................................................................

Allow serial numbers beginning with EM

Newer em100s have serial numbers beginning with EM instead of DP.

Signed-off-by: Chris Koch 
Change-Id: I6f4b3b0900fe1b5c776acd02f54ca97b31d85420
Reviewed-on: https://review.coreboot.org/c/em100/+/37624
Tested-by: build bot (Jenkins) 
Reviewed-by: Ryan O'Leary 
Reviewed-by: Stefan Reinauer 
---
M em100.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Stefan Reinauer: Looks good to me, approved
  Ryan O'Leary: Looks good to me, but someone else must approve

diff --git a/em100.c b/em100.c
index 1ee22ec..46f2c64 100644
--- a/em100.c
+++ b/em100.c
@@ -878,8 +878,10 @@
    		firmware_is_dpfw = 1;
    		break;
    	case 'x':
-			if ((optarg[0] == 'D' || optarg[0] == 'd') &&
-				(optarg[1] == 'P' || optarg[1] == 'p'))
+			if (((optarg[0] == 'D' || optarg[0] == 'd') &&
+				(optarg[1] == 'P' || optarg[1] == 'p')) ||
+				((optarg[0] == 'E' || optarg[0] == 'e') &&
+				(optarg[1] == 'M' || optarg[1] == 'm')))
    			sscanf(optarg + 2, "%d", &serial_number);
    		else
    			sscanf(optarg, "%d:%d", &bus, &device);

[ron minnich (Code Review)]

ron minnich has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37624 )

Change subject: Allow serial numbers beginning with EM
......................................................................

Patch Set 2: Code-Review+2