Attention is currently required from: Ayan Agrawal, Paul Menzel, Philipp Hug, ron minnich.
Daniel Maslowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76572?usp=email )
Change subject: Fix OpenSBI loading with working payload
......................................................................
Patch Set 9: Code-Review+1
(2 comments)
Patchset:
PS9:
I'm not too great an expert with this whole linker and build setup stuff.
Added Arthur to take another look. =)
File src/mainboard/emulation/qemu-riscv/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/76572/comment/f283f1c9_7735a946 :
PS9, Line 23: #if ENV_RAMSTAGE
Why remove the condition here? If coreboot is configured not to build a RAM stage, the pieces below […]
Huh... I realize that this part had always been before RAM stage. It's weird. Sorry!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76572?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie810c2d8f739697b17a7e707bd9ee858e3ebc8f2
Gerrit-Change-Number: 76572
Gerrit-PatchSet: 9
Gerrit-Owner: Ayan Agrawal
ayanagr03@gmail.com
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ayan Agrawal
ayanagr03@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 01 Sep 2023 13:09:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Daniel Maslowski
info@orangecms.org
Gerrit-MessageType: comment