Nathan Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32354
Change subject: mb/google/arcada: Add settings for noise mitgation ......................................................................
mb/google/arcada: Add settings for noise mitgation
Enable acoustic noise mitgation for arcada platform, the slow slew rates are fast time dived by 8.
BUG=none TEST=none
Signed-off-by: nathan chen nathan_chen@wistron.corp-partner.google.com Change-Id: I1cbcacb06d370dfcc3087db5654f2abfa147ab2a --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/32354/1
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 2056dd6..764322d 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -37,10 +37,10 @@ register "tdp_pl2_override" = "51" register "Device4Enable" = "1" register "AcousticNoiseMitigation" = "1" - register "SlowSlewRateForIa" = "0" - register "SlowSlewRateForGt" = "0" - register "SlowSlewRateForSa" = "0" - register "SlowSlewRateForFivr" = "0" + register "SlowSlewRateForIa" = "2" + register "SlowSlewRateForGt" = "2" + register "SlowSlewRateForSa" = "2" + register "SlowSlewRateForFivr" = "2" # Enable eDP device register "DdiPortEdp" = "1" # Enable HPD for DDI ports B/C
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32354 )
Change subject: mb/google/arcada: Add settings for noise mitgation ......................................................................
Patch Set 1:
Why you set this value and how to test it?
Hello Duncan Laurie, Lijian Zhao, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32354
to look at the new patch set (#2).
Change subject: mb/google/arcada: Add settings for noise mitgation ......................................................................
mb/google/arcada: Add settings for noise mitgation
Enable acoustic noise mitgation for arcada platform, the slow slew rates are fast time dived by 8.
BUG=none TEST=none
Signed-off-by: nathan chen nathan_chen@wistron.corp-partner.google.com Change-Id: I1cbcacb06d370dfcc3087db5654f2abfa147ab2a --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/32354/2
Nathan Chen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32354 )
Change subject: mb/google/arcada: Add settings for noise mitgation ......................................................................
Abandoned
setting value for SSR had been change.
-
Lijian Zhao (Code Review) -
Nathan Chen (Code Review)