Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Scott Chao.
Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54941 )
Change subject: mb/google/brya: Create primus variant
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brya/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/54941/comment/077ee268_67e05055
PS2, Line 11: select BOARD_GOOGLE_BASEBOARD_BRYA
You might want to add: […]
Done
File src/mainboard/google/brya/variants/primus/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/54941/comment/e0351a3a_fdccfbe2
PS2, Line 5: placeholder.spd.hex
This doesn't really exist. […]
With blank(only SPD_SOURCES =), I can not build coreboot successfully.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54941
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I441e4f0ebea3b9db813e321d32ca990e9c51c668
Gerrit-Change-Number: 54941
Gerrit-PatchSet: 3
Gerrit-Owner: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 27 May 2021 06:18:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment