Attention is currently required from: Martin Roth, Paul Fagerburg, Julius Werner.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54072 )
Change subject: tests: code coverage improvements
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/54072/comment/df65fd3b_09e3c2cc
PS3, Line 199: coverage_rpt
I had to add -tests to every target to get the main Makefile to use tests/Makefile.inc. […]
I was referring to directory name, not target name :)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/54072/comment/86985e79_b740d656
PS4, Line 204: COV=1 $(MAKE) coverage-report
nit: What about V=1? V=$(V) might be useful in some cases.
https://review.coreboot.org/c/coreboot/+/54072/comment/c1ccab97_152d8884
PS4, Line 207: COV=1 $(MAKE) clean-coverage-report
nit: Same as above
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54072
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bd2bfdedfab291aabeaa968c10b17e9b61c9c0a
Gerrit-Change-Number: 54072
Gerrit-PatchSet: 4
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 17 May 2021 07:15:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment