Change in ...coreboot[master]: riscv: save FDT pointer from mscratch to HLS

[Philipp Hug (Code Review)]

Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27545 )

Change subject: riscv: save FDT pointer from mscratch to HLS
......................................................................

Patch Set 27:

(4 comments)

Thanks! I like this change. Just some minor comments.
Did you test it?

https://review.coreboot.org/#/c/27545/27/src/arch/riscv/boot.c 
File src/arch/riscv/boot.c:

https://review.coreboot.org/#/c/27545/27/src/arch/riscv/boot.c@36 
PS27, Line 36: 	void (*fn)(uintptr_t a0, uintptr_t a1) = prog_entry(prog);
can you change the type of doit instead of adding another variable?

https://review.coreboot.org/#/c/27545/27/src/arch/riscv/boot.c@37 
PS27, Line 37: 	uintptr_t a0 = read_csr(mhartid);
please don't name those variables after the register. use e.g. hartid/fdt.

https://review.coreboot.org/#/c/27545/27/src/arch/riscv/boot.c@47 
PS27, Line 47: 		printk(BIOS_SPEW, "FDT is at %p\n", HLS()->fdt);
use the variable a1/fdt

https://review.coreboot.org/#/c/27545/27/src/arch/riscv/include/mcall.h 
File src/arch/riscv/include/mcall.h:

https://review.coreboot.org/#/c/27545/27/src/arch/riscv/include/mcall.h@55 
PS27, Line 55: 	void *fdt;
name it rom_fdt, because its the fdt provided by the soc rom?