Attention is currently required from: Jakub Czapiga.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59814 )
Change subject: tests: Disable -Wsource-mgr for clang
......................................................................
Patch Set 1:
(1 comment)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/59814/comment/ccaa3862_4b5d8cb4
PS1, Line 48: -Wno-source-mgr
It should probably be enclosed in check for correct version of clang. […]
Right, I thought it did that already, forgot that it needs an extra flag. GCC just seems(?) to ignore all unknown -W... by default.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59814
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie49c9eef3c74592c068c899c6717621dbcb9f609
Gerrit-Change-Number: 59814
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Comment-Date: Mon, 06 Dec 2021 17:27:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Gerrit-MessageType: comment