Attention is currently required from: Bora Guvendik, Pranava Y N, Subrata Banik.
Li1 Feng has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84998?usp=email )
Change subject: mb/google/fatcat: Add ISH support with FW_CONFIG toggle ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/fw_config.c:
https://review.coreboot.org/c/coreboot/+/84998/comment/0db8e7a3_0c18e80c?usp... : PS2, Line 469: static const struct pad_config ish_enable_pads[] = { In the enable, D5&6 are for UART0 /* GPP_D05: ISH_UART0_RXD */ PAD_CFG_NF(GPP_D05, NONE, DEEP, NF2), /* GPP_D06: ISH_UART0_TXD */ PAD_CFG_NF(GPP_D06, NONE, DEEP, NF2), currently we don't use I3C, H14&15 can be moved out and set to NC.
D07&08 also can be NC all the time. /* GPP_D07: Not used */ PAD_NC(GPP_D07, NONE), /* GPP_D08: Not used */ PAD_NC(GPP_D08, NONE),