Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Kane Chen, Karthik Ramasubramanian.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57686 )
Change subject: soc/intel/common: Add crashlog records to BERT
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/soc/intel/common/block/acpi/acpi_bert.c:
https://review.coreboot.org/c/coreboot/+/57686/comment/99484018_6310e6a3
PS3, Line 34: if (cpu_entry)
This check isn't needed, it's covered on line 24.
https://review.coreboot.org/c/coreboot/+/57686/comment/8e8dec6e_f1ad3af7
PS3, Line 52: if (pmc_entry)
This check isn't needed, it's covered on line 24.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57686
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I646053e00fbe4649d5fdcc7ae91dfa8477a5ae65
Gerrit-Change-Number: 57686
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 04 Oct 2021 18:55:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment