Change in coreboot[master]: soc/intel: hook up new gpio device in the soc chips

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48583 )

Change subject: soc/intel: hook up new gpio device in the soc chips
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48583/7/src/soc/intel/alderlake/chi... 
File src/soc/intel/alderlake/chip.c:

https://review.coreboot.org/c/coreboot/+/48583/7/src/soc/intel/alderlake/chi... 
PS7, Line 202: else if (dev->path.type == DEVICE_PATH_GPIO)
             : 		dev->ops = &soc_gpio_ops;
> Ah thanks, that could indeed work - I tried this before but wasn't sure how we get the ops assigned  […]

Uhm, wait... no. That will *not* work....

Example:

chip soc/intel/whateverlake

dev gpio 0 alias soc_gpio on end

chip this/is/another/chip
    dev gpio 0 alias chip_gpio on end
  end

chip blah/bmc
    use chip_gpio as gpio
  end

chip no/idea
    use soc_gpio as gpio
  end
end

With your code the block gpio driver will get assigned to both gpio devices which is obviously wrong.