[S] Change in coreboot[master]: drivers/ocp/dmi: Fix smbios type 11 get wrong ppin value for second s...
Attention is currently required from: Angel Pons, Shuming Chu (Shuming), Arthur Heymans, TangYiwei, Tim Chu.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68910 )
Change subject: drivers/ocp/dmi: Fix smbios type 11 get wrong ppin value for second socket ......................................................................
Patch Set 5: Code-Review+2
(3 comments)
File src/drivers/ocp/dmi/smbios.c:
https://review.coreboot.org/c/coreboot/+/68910/comment/b3ce8123_19fc9a3e PS4, Line 205: static int get_logic_cpu(int node)
Should we name the variable as socket instead of node?
Ack
https://review.coreboot.org/c/coreboot/+/68910/comment/5989a2a3_c7a3eb21 PS4, Line 207: for (int logic_cpu = 0; logic_cpu < CONFIG_MAX_CPUS; logic_cpu++) {
Should we loop through all logical cpus, instead of all sockets (CPUs)?
Ack
https://review.coreboot.org/c/coreboot/+/68910/comment/5c1d6c5f_44e209e3 PS4, Line 259: get_logic_cpu(1), 100 * USECS_PER_MSEC) !=
Looks like it wouldn't do anything, but it would be wise to add a check.
Ack
-
Jonathan Zhang (Code Review)