Attention is currently required from: Rob Barnes, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62599 )
Change subject: mb/google/guybrush: Enable EC SMI handler ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62599/comment/3df50e3a_f83bff0f PS1, Line 10: are disabled once ACPI is : enabled
Just for my knowledge, what component writes to ACPI SMI command port and triggers this ACPI Enable […]
The OS does it. We pass the SMI values to enable/disable ACPI via the FADT table. https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
File src/mainboard/google/guybrush/smihandler.c:
https://review.coreboot.org/c/coreboot/+/62599/comment/a280454a_abc8313a PS1, Line 48: chromeec_smi_process_events();
Does this end up handling the LID_CLOSED event as an SMI event when OS is expected to handle it.
EC SMI events are only enabled when ACPI is disabled.
https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
i.e., last parts of coreboot, depthcharge and OS before ACPI is enabled. It's kind of a nice fallback in case depthcharge locks up.
-
Raul Rangel (Code Review)