Attention is currently required from: Angel Pons, Fabian Groffen, Felix Singer, Keith Hui, Kevin Keijzer.
Keith Hui has posted comments on this change by Kevin Keijzer. ( https://review.coreboot.org/c/coreboot/+/78806?usp=email )
Change subject: mb/asus/p8x7x-series: Add P8H77-M as a variant
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/asus/p8x7x-series/variants/p8h77-m/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/78806/comment/c73d5d59_9a3232c1?usp... :
PS6, Line 16: device pnp 2e.1 off end # Parallel
You want this on and configured. P8H77-M does have LPT port wired up.
https://review.coreboot.org/c/coreboot/+/78806/comment/446c31f0_56ca6f6e?usp... :
PS6, Line 29: drq 0x22 = 0xd7 # Power down UART B and LPT
Don't power down LPT.
```suggestion
drq 0x22 = 0xdf # Power down UART B
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78806?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I846e61303db0ad24569dcb713f0505d670fde1bd
Gerrit-Change-Number: 78806
Gerrit-PatchSet: 6
Gerrit-Owner: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Fabian Groffen
grobian@gentoo.org
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Keith Hui
buurin@gmail.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Fabian Groffen
grobian@gentoo.org
Gerrit-Comment-Date: Sat, 08 Jun 2024 19:48:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No