Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37147 )
Change subject: Really fix the chip detection ......................................................................
Really fix the chip detection
if (!chip) is still always wrong (because it comes from an array)
Signed-off-by: Patrick Georgi pgeorgi@google.com Change-Id: Idf472003e5d0ab65c8e1c5acb61b416720cd317f --- M em100.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/47/37147/1
diff --git a/em100.c b/em100.c index 50b04b4..c806413 100644 --- a/em100.c +++ b/em100.c @@ -626,7 +626,7 @@ break; }
- if (!chip) + if (!chip->name) return 1;
*out = chip;
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37147 )
Change subject: Really fix the chip detection ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/em100/+/37147 )
Change subject: Really fix the chip detection ......................................................................
Really fix the chip detection
if (!chip) is still always wrong (because it comes from an array)
Signed-off-by: Patrick Georgi pgeorgi@google.com Change-Id: Idf472003e5d0ab65c8e1c5acb61b416720cd317f Reviewed-on: https://review.coreboot.org/c/em100/+/37147 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M em100.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/em100.c b/em100.c index 50b04b4..c806413 100644 --- a/em100.c +++ b/em100.c @@ -626,7 +626,7 @@ break; }
- if (!chip) + if (!chip->name) return 1;
*out = chip;
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)