Change in coreboot[master]: Documentation/acpi: Fix the path to variants/hatch/overridetree.cb

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

1 Apr 2020 1 Apr '20

8:36 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40012 )

Change subject: Documentation/acpi: Fix the path to variants/hatch/overridetree.cb ......................................................................

Documentation/acpi: Fix the path to variants/hatch/overridetree.cb

Change-Id: I7c3fd942318f28b4714bc7c2a47bedf85f7923ed Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Documentation/acpi/devicetree.md 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/40012/1

diff --git a/Documentation/acpi/devicetree.md b/Documentation/acpi/devicetree.md index 556c966..39358bd 100644 --- a/Documentation/acpi/devicetree.md +++ b/Documentation/acpi/devicetree.md @@ -23,7 +23,7 @@ ## Device drivers

Let's take a look at an example entry from -``src/mainboard/google/hatch/variant/hatch/overridetree.cb``: +``src/mainboard/google/hatch/variants/hatch/overridetree.cb``:

``` device pci 15.0 on

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Christian Walter (Code Review)

1 Apr 1 Apr

11:56 a.m.

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40012 )

Change subject: Documentation/acpi: Fix the path to variants/hatch/overridetree.cb ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/40012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c3fd942318f28b4714bc7c2a47bedf85f7923ed Gerrit-Change-Number: 40012 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 01 Apr 2020 14:56:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

18 May 18 May

6:57 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40012 )

Change subject: Documentation/acpi: Fix the path to variants/hatch/overridetree.cb ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/40012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c3fd942318f28b4714bc7c2a47bedf85f7923ed Gerrit-Change-Number: 40012 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 18 May 2020 09:57:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

19 May 19 May

1:56 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40012 )

Change subject: Documentation/acpi: Fix the path to variants/hatch/overridetree.cb ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c3fd942318f28b4714bc7c2a47bedf85f7923ed Gerrit-Change-Number: 40012 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 19 May 2020 16:56:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

26 May 26 May

11:58 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40012 )

Change subject: Documentation/acpi: Fix the path to variants/hatch/overridetree.cb ......................................................................

Documentation/acpi: Fix the path to variants/hatch/overridetree.cb

Change-Id: I7c3fd942318f28b4714bc7c2a47bedf85f7923ed Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/40012 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Christian Walter christian.walter@9elements.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Documentation/acpi/devicetree.md 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Christian Walter: Looks good to me, but someone else must approve

diff --git a/Documentation/acpi/devicetree.md b/Documentation/acpi/devicetree.md index c3c4c2e..e8680e3 100644 --- a/Documentation/acpi/devicetree.md +++ b/Documentation/acpi/devicetree.md @@ -23,7 +23,7 @@ ## Device drivers

Let's take a look at an example entry from -``src/mainboard/google/hatch/variant/hatch/overridetree.cb``: +``src/mainboard/google/hatch/variants/hatch/overridetree.cb``:

``` device pci 15.0 on

-- To view, visit https://review.coreboot.org/c/coreboot/+/40012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c3fd942318f28b4714bc7c2a47bedf85f7923ed Gerrit-Change-Number: 40012 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

12:12 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40012 )

Change subject: Documentation/acpi: Fix the path to variants/hatch/overridetree.cb ......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4019 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4018 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4017 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4016

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/40012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c3fd942318f28b4714bc7c2a47bedf85f7923ed Gerrit-Change-Number: 40012 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Tue, 26 May 2020 15:12:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1790

days inactive

1845

days old

coreboot-gerrit@coreboot.org

5 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Angel Pons (Code Review)
Christian Walter (Code Review)
HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)