Attention is currently required from: Angel Pons.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34834 )
Change subject: nb/intel/gm45: Add remaining raminit code to support DDR2
......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/34834/comment/9bd1256c_b1cb02c2
PS2, Line 7: DDR2 remainders
Add a verb?
Done
File src/northbridge/intel/gm45/raminit_receive_enable_calibration.c:
https://review.coreboot.org/c/coreboot/+/34834/comment/9d25017c_7de67676
PS2, Line 221: : 15;
Nit: could be on the previous line.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34834
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d9a1853fea9e29171d7c2f9ffe7086685c9efad
Gerrit-Change-Number: 34834
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 17 Dec 2022 04:18:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment