Attention is currently required from: Nico Huber, Michael Niewöhner, Werner Zeh.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52809 )
Change subject: treewide: Kconfig: replace `def_bool n` by `bool`
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
It's actually the other way round. […]
Types cannot be overridden. The type is only required in a single place, though it's typically included everywhere.
For the prompts with defaults, I moved the default to the end of the src/Kconfig file. This is really the only spot where it's critical because the general menu is at the very top, ahead of the mainboard or chipset menus.
To me 'dev_bool n' is more than just "I don't care what the default is, so set it to n if nobody else sets it to y. It's a signal saying that n SHOULD be the default option. We lose that signal with this change.
Why is this change necessary? You say that the def_bool n isn't needed, but is it hurting anything? My thought is that it doesn't hurt anything, so let's just leave it as it is and not touch files all across the codebase.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52809
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27e89c66d18b7b3a5ac425eacea10df8c013814f
Gerrit-Change-Number: 52809
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 05 May 2021 19:27:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment