Attention is currently required from: Raul Rangel, Rob Barnes.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63598 )
Change subject: util/apcb/apcb_v3_edit.py: Edit APCB based on different SPD magic
......................................................................
Patch Set 2:
(3 comments)
File util/apcb/apcb_v3_edit.py:
https://review.coreboot.org/c/coreboot/+/63598/comment/35dd24f2_a091b14f
PS1, Line 51: '--spd_magic',
How about adding a --memory_type [lp4 | lp5] argument? Then we can keep the SPD magic numbers define […]
Done
https://review.coreboot.org/c/coreboot/+/63598/comment/78500387_3703247b
PS1, Line 84: if args.spd_magic:
: SPD_MAGIC = bytes.fromhex(args.spd_magic)
Can you use a local variable instead? […]
Done
https://review.coreboot.org/c/coreboot/+/63598/comment/1ae05469_289e3189
PS1, Line 97: SPD_MAGIC
Switch this to use `spd_magic`
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63598
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e96c89e4e5ce8e0567a17bf7685b69080fa1708
Gerrit-Change-Number: 63598
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Wed, 13 Apr 2022 19:50:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment