Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Julius Werner, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun.
Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86283?usp=email )
Change subject: lib: Refactor ux_locales_get_text API ......................................................................
Patch Set 2:
(9 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86283/comment/566290b7_c1dec45c?usp... : PS2, Line 14: - ux_locales_get_text: Get UX locales msg based on locales name. message.
https://review.coreboot.org/c/coreboot/+/86283/comment/0870851d_e2fe18df?usp... : PS2, Line 15: msg message
https://review.coreboot.org/c/coreboot/+/86283/comment/453a076e_25a9df8d?usp... : PS2, Line 15: - ux_locales_get_text_by_id - Get UX locales msg based on msg ID. Use colon instead of dash
https://review.coreboot.org/c/coreboot/+/86283/comment/97af349f_bbcbcc9a?usp... : PS2, Line 17: `ux_locales_get_text_by_id` retrieve fallback text message depending retrieves
https://review.coreboot.org/c/coreboot/+/86283/comment/61ecef9c_0792bd1c?usp... : PS2, Line 18: upon the msg ID incase UX locales not available. `ux_locales_get_text` s/incase/if/
File src/include/ux_locales.h:
https://review.coreboot.org/c/coreboot/+/86283/comment/1082dafe_e5f1ea55?usp... : PS2, Line 20: english English
https://review.coreboot.org/c/coreboot/+/86283/comment/d3358ea5_87bb73d1?usp... : PS2, Line 20: fallback_msg fallback_text ?
File src/lib/ux_locales.c:
https://review.coreboot.org/c/coreboot/+/86283/comment/deb27f74_7a2c374b?usp... : PS2, Line 35: ux_locale_msg_list Could we index with `enum ux_locale_msg` avoiding an unnecessary loop?
https://review.coreboot.org/c/coreboot/+/86283/comment/ff32661d_30b207ff?usp... : PS2, Line 225: if (!msg_id_found) I am wondering if a `printk(BIOS_ERR` would be appropriate in addition to this.
-
Jérémy Compostella (Code Review)