Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56275 )
Change subject: soc/amd/picasso: implement and use mca_is_valid_bank ......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/picasso/mca.c:
https://review.coreboot.org/c/coreboot/+/56275/comment/91396989_6454bbb8 PS1, Line 197: continue
Should we print a warning saying that bank is not valid?
at least on stoneyridge doing that would cause false warnings. see https://review.coreboot.org/c/coreboot/+/56277/1/src/soc/amd/stoneyridge/mca... where the same mechanism is used to be able to skip one mca bank that's not fully implemented and will cause a general protection fault if at least some registers are accessed.
haven't finished the full patch series yer, but basically my plan is to implement mca_is_valid_bank and mca_get_bank_name to access mca_bank_name[] for each soc and have one common non-x mca implementation and one common mcax implementation with some common mca code that is common for both mca and mcax
-
Felix Held (Code Review)