HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32883
Change subject: mb/asus/kgpe-d16: Add DIMM_MAX to Kconfig ......................................................................
mb/asus/kgpe-d16: Add DIMM_MAX to Kconfig
Default DIMM_MAX is 4 however kgpe-d16 has 16 DIMM slots and high expandability with 6 expansion slots.
Change-Id: Id7150f85138b9a22b07f6abdbb0acedccfbf6fde Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/kgpe-d16/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/32883/1
diff --git a/src/mainboard/asus/kgpe-d16/Kconfig b/src/mainboard/asus/kgpe-d16/Kconfig index 32c4dbc..03917c1 100644 --- a/src/mainboard/asus/kgpe-d16/Kconfig +++ b/src/mainboard/asus/kgpe-d16/Kconfig @@ -95,6 +95,10 @@ string default "1a03,2000"
+config DIMM_MAX + int + default 22 + config MAX_REBOOT_CNT int default 10
Hello Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32883
to look at the new patch set (#2).
Change subject: mb/asus/kgpe-d16: Add DIMM_MAX to kgpe-d16's Kconfig file ......................................................................
mb/asus/kgpe-d16: Add DIMM_MAX to kgpe-d16's Kconfig file
Default DIMM_MAX is 4 however kgpe-d16 has 16 DIMM slots and high expandability with 6 expansion slots.
Change-Id: Id7150f85138b9a22b07f6abdbb0acedccfbf6fde Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/kgpe-d16/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/32883/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32883 )
Change subject: mb/asus/kgpe-d16: Add DIMM_MAX to kgpe-d16's Kconfig file ......................................................................
Patch Set 1: Code-Review-1
I can't see where the KGPE-D16 makes use of CONFIG_DIMM_MAX.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32883 )
Change subject: mb/asus/kgpe-d16: Add DIMM_MAX to kgpe-d16's Kconfig file ......................................................................
Patch Set 2:
I can't see where the KGPE-D16 makes use of CONFIG_DIMM_MAX.
if I'm not wrong, here: nano +645 src/mainboard/asus/kgpe-d16/romstage.c
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32883 )
Change subject: mb/asus/kgpe-d16: Add DIMM_MAX to kgpe-d16's Kconfig file ......................................................................
Patch Set 2:
I can't see where the KGPE-D16 makes use of CONFIG_DIMM_MAX.
if I'm not wrong, here: nano +645 src/mainboard/asus/kgpe-d16/romstage.c
heu... NO! I'm wrong
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32883 )
Change subject: mb/asus/kgpe-d16: Add DIMM_MAX to kgpe-d16's Kconfig file ......................................................................
Abandoned
CONFIG_DIMM_MAX not used
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)