Attention is currently required from: Anil Kumar K, Tarun Tuli, Jamie Ryu, Subrata Banik, Paul Menzel, Kapil Porwal, Sridhar Siricilla.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74763 )
Change subject: soc/intel/meteorlake: Allow option to perform CSE sync at romstage
......................................................................
Patch Set 7: Verified-1
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175113):
https://review.coreboot.org/c/coreboot/+/74763/comment/4b7c1be7_ff2b4e51
PS7, Line 9: The change 'commit 248dbe0908f1b ("Trigger cse_fw_sync before
Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 248dbe0908f1 ("soc/intel/alderlake: Trigger cse_fw_sync before DRAM Init")'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74763
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e603a2ecf1a67ee7c683b440072889d137f9de0
Gerrit-Change-Number: 74763
Gerrit-PatchSet: 7
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-Comment-Date: Thu, 27 Apr 2023 12:32:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment