Change in coreboot[master]: soc/intel/icelake: Make use of PCH_DEV_SLOT_ESPI macro

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34286 )

Change subject: soc/intel/icelake: Make use of PCH_DEV_SLOT_ESPI macro
......................................................................

soc/intel/icelake: Make use of PCH_DEV_SLOT_ESPI macro

Change-Id: I3be530072a6981760e9fe31e43741b4b480d045e
Signed-off-by: Subrata Banik 
---
M src/soc/intel/icelake/romstage/fsp_params.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/34286/1

diff --git a/src/soc/intel/icelake/romstage/fsp_params.c b/src/soc/intel/icelake/romstage/fsp_params.c
index 420c427..dd87617 100644
--- a/src/soc/intel/icelake/romstage/fsp_params.c
+++ b/src/soc/intel/icelake/romstage/fsp_params.c
@@ -38,7 +38,7 @@
    m_cfg->SkipMbpHob = 1;

/* If Audio Codec is enabled, enable FSP UPD */
-	dev = pcidev_on_root(0x1f, 3);
+	dev = pcidev_on_root(PCH_DEV_SLOT_ESPI, 3);
    if (!dev)
    	m_cfg->PchHdaEnable = 0;
    else

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34286 )

Change subject: soc/intel/icelake: Make use of PCH_DEV_SLOT_ESPI macro
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34286/1/src/soc/intel/icelake/romst... 
File src/soc/intel/icelake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/34286/1/src/soc/intel/icelake/romst... 
PS1, Line 41: cidev_on_root(PCH_DEV_SLOT_ESPI, 3)
Just use: pcidev_path_on_root(PCH_DEVFN_HDA);

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34286 )

Change subject: soc/intel/icelake: Make use of PCH_DEV_SLOT_ESPI macro
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34286/1/src/soc/intel/icelake/romst... 
File src/soc/intel/icelake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/34286/1/src/soc/intel/icelake/romst... 
PS1, Line 41: cidev_on_root(PCH_DEV_SLOT_ESPI, 3)
> Just use: pcidev_path_on_root(PCH_DEVFN_HDA);

Ack

Change in coreboot[master]: soc/intel/icelake: Make use of PCH_DEVFN_HDA macro

[Subrata Banik (Code Review)]

Hello Patrick Rudolph, Aamir Bohra, Paul Menzel, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34286

to look at the new patch set (#2).

Change subject: soc/intel/icelake: Make use of PCH_DEVFN_HDA macro
......................................................................

soc/intel/icelake: Make use of PCH_DEVFN_HDA macro

Change-Id: I3be530072a6981760e9fe31e43741b4b480d045e
Signed-off-by: Subrata Banik 
---
M src/soc/intel/icelake/romstage/fsp_params.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/34286/2

Change in coreboot[master]: soc/intel/icelake: Make use of PCH_DEVFN_HDA macro

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34286 )

Change subject: soc/intel/icelake: Make use of PCH_DEVFN_HDA macro
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: soc/intel/icelake: Make use of PCH_DEVFN_HDA macro

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34286 )

Change subject: soc/intel/icelake: Make use of PCH_DEVFN_HDA macro
......................................................................

soc/intel/icelake: Make use of PCH_DEVFN_HDA macro

Change-Id: I3be530072a6981760e9fe31e43741b4b480d045e
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34286
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
---
M src/soc/intel/icelake/romstage/fsp_params.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/soc/intel/icelake/romstage/fsp_params.c b/src/soc/intel/icelake/romstage/fsp_params.c
index 420c427..4801bd9 100644
--- a/src/soc/intel/icelake/romstage/fsp_params.c
+++ b/src/soc/intel/icelake/romstage/fsp_params.c
@@ -38,7 +38,7 @@
    m_cfg->SkipMbpHob = 1;

/* If Audio Codec is enabled, enable FSP UPD */
-	dev = pcidev_on_root(0x1f, 3);
+	dev = pcidev_path_on_root(PCH_DEVFN_HDA);
    if (!dev)
    	m_cfg->PchHdaEnable = 0;
    else