Attention is currently required from: Lance Zhao, Marc Jones, Anjaneya "Reddy" Chagam, Martin Roth, Johnny Lin, Rocky Phagura, David Hendricks, Angel Pons, Morgan Jang, Patrick Rudolph, Tim Chu.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52090 )
Change subject: src/intel/xeon_sp: add hardware error support (HEST)
......................................................................
Patch Set 13:
(2 comments)
File src/soc/intel/xeon_sp/include/soc/hest.h:
https://review.coreboot.org/c/coreboot/+/52090/comment/00adefbb_74e70112
PS13, Line 18:
: typedef struct acpi_gen_regaddr1 {
: u8 space_id; /* Address space ID */
: u8 bit_width; /* Register size in bits */
: u8 bit_offset; /* Register bit offset */
: u8 access_size; /* Access size since ACPI 2.0c */
: u64 addr; /* Register address */
: } __packed acpi_addr64_t;
This is in `acpi.h` now CB:49286 😉
File src/soc/intel/xeon_sp/uncore.c:
https://review.coreboot.org/c/coreboot/+/52090/comment/60455812_2f4b929b
PS13, Line 292: /* Reserve memory for Enhanced error logging */
: if (CONFIG(SOC_RAS_ELOG)) {
: base_kb = cbmem_top_addr >> 10;
: size_kb = CONFIG_ERROR_LOG_BUFFER_SIZE >> 10;
: LOG_MEM_RESOURCE("elog_sts_blk", dev, index, base_kb, size_kb);
: reserved_ram_resource(dev, index++, base_kb, size_kb);
: elog_addr = cbmem_top_addr;
: printk(BIOS_DEBUG, "%s elog_addr = %llx size = %x\n",
: __func__, elog_addr, CONFIG_ERROR_LOG_BUFFER_SIZE);
: }
:
If I understand what you're doing correctly (trying to reserve CONFIG_ERROR_LOG_BUFFER_SIZE >> 10 bytes worth of memory in cbmem? You need to account for this used memory in cbmem so it knows about it, `cbmem_add`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If76b2af153616182cc053ca878f30fe056e9c8bd
Gerrit-Change-Number: 52090
Gerrit-PatchSet: 13
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Rocky Phagura
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 03 May 2021 21:23:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment