Hello Seunghwan Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34985
to review the following change.
Change subject: mb/google/kohaku: Correct DPTF temp sensor IDs ......................................................................
mb/google/kohaku: Correct DPTF temp sensor IDs
This change corrects DPTF temperature sensor IDs
BUG=none BRANCH=none TEST=none
Change-Id: I25c76b0e938b2568da1833a4a5685ed36c00275e Signed-off-by: Seunghwan Kim sh_.kim@samsung.com --- M src/mainboard/google/hatch/variants/kohaku/include/variant/acpi/dptf.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/34985/1
diff --git a/src/mainboard/google/hatch/variants/kohaku/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/kohaku/include/variant/acpi/dptf.asl index f6fd907..375be8e 100644 --- a/src/mainboard/google/hatch/variants/kohaku/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/kohaku/include/variant/acpi/dptf.asl @@ -26,12 +26,12 @@ #define DPTF_TSR1_PASSIVE 65 #define DPTF_TSR1_CRITICAL 75
-#define DPTF_TSR2_SENSOR_ID 1 +#define DPTF_TSR2_SENSOR_ID 2 #define DPTF_TSR2_SENSOR_NAME "Thermal Sensor - IA" #define DPTF_TSR2_PASSIVE 65 #define DPTF_TSR2_CRITICAL 75
-#define DPTF_TSR3_SENSOR_ID 1 +#define DPTF_TSR3_SENSOR_ID 3 #define DPTF_TSR3_SENSOR_NAME "Thermal Sensor - GT" #define DPTF_TSR3_PASSIVE 65 #define DPTF_TSR3_CRITICAL 75
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34985 )
Change subject: mb/google/kohaku: Correct DPTF temp sensor IDs ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34985 )
Change subject: mb/google/kohaku: Correct DPTF temp sensor IDs ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34985 )
Change subject: mb/google/kohaku: Correct DPTF temp sensor IDs ......................................................................
mb/google/kohaku: Correct DPTF temp sensor IDs
This change corrects DPTF temperature sensor IDs
BUG=none BRANCH=none TEST=none
Change-Id: I25c76b0e938b2568da1833a4a5685ed36c00275e Signed-off-by: Seunghwan Kim sh_.kim@samsung.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34985 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/kohaku/include/variant/acpi/dptf.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Paul Fagerburg: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/kohaku/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/kohaku/include/variant/acpi/dptf.asl index f6fd907..375be8e 100644 --- a/src/mainboard/google/hatch/variants/kohaku/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/kohaku/include/variant/acpi/dptf.asl @@ -26,12 +26,12 @@ #define DPTF_TSR1_PASSIVE 65 #define DPTF_TSR1_CRITICAL 75
-#define DPTF_TSR2_SENSOR_ID 1 +#define DPTF_TSR2_SENSOR_ID 2 #define DPTF_TSR2_SENSOR_NAME "Thermal Sensor - IA" #define DPTF_TSR2_PASSIVE 65 #define DPTF_TSR2_CRITICAL 75
-#define DPTF_TSR3_SENSOR_ID 1 +#define DPTF_TSR3_SENSOR_ID 3 #define DPTF_TSR3_SENSOR_NAME "Thermal Sensor - GT" #define DPTF_TSR3_PASSIVE 65 #define DPTF_TSR3_CRITICAL 75
-
Furquan Shaikh (Code Review) -
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)
-
shkim (Code Review)