Attention is currently required from: Nick Vaccaro.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79102?usp=email )
Change subject: Fix configuration for TPM in Kconfig
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/79102/comment/bf6de84d_eab18b33 :
PS1, Line 90: 33
How was this number determined?
Hi Nick,
I got this from the definition of GPE0_DW1_01 in src/soc/intel/common/pch/include/intelpch/gpe.h:
#define GPE0_DW1_01 33
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79102?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0ecaa6fcfc05c3c2e55f857d7a4e59fe46096bb5
Gerrit-Change-Number: 79102
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Fri, 17 Nov 2023 22:02:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment