Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/28385 )
Change subject: intel/fsp2_0: automatically split FSP into fsp{t,m,s}.bin ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/28385/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/28385/1//COMMIT_MSG@9 PS1, Line 9: splited split
https://review.coreboot.org/#/c/28385/1/src/drivers/intel/fsp2_0/Makefile.in... File src/drivers/intel/fsp2_0/Makefile.inc:
https://review.coreboot.org/#/c/28385/1/src/drivers/intel/fsp2_0/Makefile.in... PS1, Line 23: python Better let the shebang decide. FYI, python2 is EOL in 16 months.
https://review.coreboot.org/#/c/28385/1/src/drivers/intel/fsp2_0/Makefile.in... PS1, Line 23: $(info $(shell python ./util/fsptool/SplitFsp.py $(FAMILY))) This will be executed every time even when nothing changes. Better define targets and a recipe, I guess.
-
Alex Thiessen (Code Review)