Change in ...coreboot[master]: Makefile.inc: Update 3rdparty/intel-microcode on USE_BLOBS
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33553
Change subject: Makefile.inc: Update 3rdparty/intel-microcode on USE_BLOBS ......................................................................
Makefile.inc: Update 3rdparty/intel-microcode on USE_BLOBS
Change-Id: I0caeff3ff5613a594a79441e849440ebdc9a9b87 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/33553/1
diff --git a/Makefile.inc b/Makefile.inc index 2ba9446..48879bc 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -193,9 +193,10 @@ # try to fetch non-optional submodules if the source is under git forgetthis:=$(if $(GIT),$(shell git submodule update --init)) ifeq ($(CONFIG_USE_BLOBS),y) -# this is necessary because 3rdparty/blobs is update=none, and so is ignored +# this is necessary because 3rdparty/{blobs,intel-microcode} is update=none, and so is ignored # unless explicitly requested and enabled through --checkout forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/blobs)) +forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/intel-microcode)) ifeq ($(CONFIG_PLATFORM_USES_FSP1_0)$(CONFIG_PLATFORM_USES_FSP1_1)$(CONFIG_PLATFORM_USES_FSP2_0),y) # this is necessary because 3rdparty/fsp is update=none, and so is ignored # unless explicitly requested and enabled through --checkout
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33553 )
Change subject: Makefile.inc: Update 3rdparty/intel-microcode on USE_BLOBS ......................................................................
Patch Set 3: Code-Review+2
Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33553 )
Change subject: Makefile.inc: Update 3rdparty/intel-microcode on USE_BLOBS ......................................................................
Makefile.inc: Update 3rdparty/intel-microcode on USE_BLOBS
Change-Id: I0caeff3ff5613a594a79441e849440ebdc9a9b87 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/33553 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/Makefile.inc b/Makefile.inc index 2ba9446..48879bc 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -193,9 +193,10 @@ # try to fetch non-optional submodules if the source is under git forgetthis:=$(if $(GIT),$(shell git submodule update --init)) ifeq ($(CONFIG_USE_BLOBS),y) -# this is necessary because 3rdparty/blobs is update=none, and so is ignored +# this is necessary because 3rdparty/{blobs,intel-microcode} is update=none, and so is ignored # unless explicitly requested and enabled through --checkout forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/blobs)) +forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/intel-microcode)) ifeq ($(CONFIG_PLATFORM_USES_FSP1_0)$(CONFIG_PLATFORM_USES_FSP1_1)$(CONFIG_PLATFORM_USES_FSP2_0),y) # this is necessary because 3rdparty/fsp is update=none, and so is ignored # unless explicitly requested and enabled through --checkout
-
Arthur Heymans (Code Review) -
Nico Huber (Code Review)
-
Philipp Deppenwiese (Code Review)