Change in coreboot[master]: payloads/external/FILO: Pass Libpayloads path on the clean target
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36461 )
Change subject: payloads/external/FILO: Pass Libpayloads path on the clean target ......................................................................
payloads/external/FILO: Pass Libpayloads path on the clean target
Change-Id: If5f8f4ecce317e54cd4b5688553cc38220f6e6df Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M payloads/external/FILO/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/36461/1
diff --git a/payloads/external/FILO/Makefile b/payloads/external/FILO/Makefile index a89ea2a..ffb4e1f 100644 --- a/payloads/external/FILO/Makefile +++ b/payloads/external/FILO/Makefile @@ -44,7 +44,7 @@ $(MAKE) && $(MAKE) DESTDIR=../external/FILO/filo/build install
clean: - test -d filo && $(MAKE) -C filo clean || exit 0 + test -d filo && $(MAKE) -C filo clean LIBCONFIG_PATH=../../../libpayload || exit 0
distclean: rm -rf filo
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36461 )
Change subject: payloads/external/FILO: Pass Libpayloads path on the clean target ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36461/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36461/2//COMMIT_MSG@8 PS2, Line 8: To fix what problem?
Nico Huber has uploaded a new patch set (#3) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/36461 )
Change subject: payloads/external/FILO: Pass Libpayloads path on the clean target ......................................................................
payloads/external/FILO: Pass Libpayloads path on the clean target
FILO's Makefile will check for libpayload and might not even `clean` if it's not found.
Change-Id: If5f8f4ecce317e54cd4b5688553cc38220f6e6df Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M payloads/external/FILO/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/36461/3
Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer, Arthur Heymans. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36461 )
Change subject: payloads/external/FILO: Pass Libpayloads path on the clean target ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/36461/comment/aa07293f_56265a05 PS2, Line 8:
To fix what problem?
A check for libpayload in FILO's Makefile could prevent to do anything.
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36461 )
Change subject: payloads/external/FILO: Pass Libpayloads path on the clean target ......................................................................
payloads/external/FILO: Pass Libpayloads path on the clean target
FILO's Makefile will check for libpayload and might not even `clean` if it's not found.
Change-Id: If5f8f4ecce317e54cd4b5688553cc38220f6e6df Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36461 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M payloads/external/FILO/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/payloads/external/FILO/Makefile b/payloads/external/FILO/Makefile index 6175cfe..9089557 100644 --- a/payloads/external/FILO/Makefile +++ b/payloads/external/FILO/Makefile @@ -44,7 +44,7 @@ $(MAKE) && $(MAKE) DESTDIR=../external/FILO/filo/build install
clean: - test -d filo && $(MAKE) -C filo clean || exit 0 + test -d filo && $(MAKE) -C filo clean LIBCONFIG_PATH=../../../libpayload || exit 0
distclean: rm -rf filo
-
Arthur Heymans (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)