Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38838 )
Change subject: cpu: Add initial xeonsp support broilerplate ......................................................................
Patch Set 2:
(4 comments)
Please make the spelling in the copyright header consistent, or move to SPDX.
https://review.coreboot.org/c/coreboot/+/38838/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38838/2//COMMIT_MSG@7 PS2, Line 7: broilerplate boilerplate?
https://review.coreboot.org/c/coreboot/+/38838/2//COMMIT_MSG@14 PS2, Line 14: Change-Id: I24346b8a5c30342419db23b5f1adf27d4d0ebc5f Missing Signed-off-by line.
https://review.coreboot.org/c/coreboot/+/38838/2/src/cpu/intel/xeonsp/bootbl... File src/cpu/intel/xeonsp/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38838/2/src/cpu/intel/xeonsp/bootbl... PS2, Line 4: * Copyright (C) 2019 Facebook Inc Inc.?
https://review.coreboot.org/c/coreboot/+/38838/2/src/cpu/intel/xeonsp/bootbl... PS2, Line 38: {0} Please add spaces around the 0.
-
Paul Menzel (Code Review)