Nico Huber has posted comments on this change. ( https://review.coreboot.org/28872 )
Change subject: src/lib/edid.c: Replace #if 1 with something useful ......................................................................
Patch Set 1:
(1 comment)
A bit too much bikeshedding (this crappy EDID code usually doesn't deserve my attention) but ignoring what dark corner this is about: we can do better ;)
https://review.coreboot.org/#/c/28872/1/src/lib/edid.c File src/lib/edid.c:
https://review.coreboot.org/#/c/28872/1/src/lib/edid.c@207 PS1, Line 207: #if CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8 `> 8` means BIOS_NEVER. Probably not the intention, writing `> BIOS_SPEW` would have made that obvious :-P
Also I see no real benefit of an #if at all. It's ramstage code (we don't have to save every single byte in flash) and it doesn't have side effects (beside the potential log output). And, anyway, you could write it in C and it would still be dropped from the binary in case:
if (IS_ENABLED(CONFIG_DEFAULT_CONSOLE_LOGLEVEL_8)) {
-
Nico Huber (Code Review)